Skip to content

refactor: Reduce VideoConfContext exhausting types#35047

Merged
kodiakhq[bot] merged 8 commits intodevelopfrom
refactor/exhausting-types-videoconf
Feb 4, 2025
Merged

refactor: Reduce VideoConfContext exhausting types#35047
kodiakhq[bot] merged 8 commits intodevelopfrom
refactor/exhausting-types-videoconf

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 28, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

This PR aims to reduce the exhausting types from VideoConfContext and memoizes SyncExternalStore queries. It also helps to create and use mocks in mock-providers package, allowing to introduce unit tests

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 28, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c01d3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.4.0 milestone Jan 28, 2025
@dougfabris dougfabris changed the title refactor: Reduce VideoConf exhausting types refactor: Reduce VideoConfContext exhausting types Jan 28, 2025
@dougfabris dougfabris force-pushed the refactor/exhausting-types-videoconf branch from d21c733 to a1bdf77 Compare January 28, 2025 19:17
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35047/

Built to branch gh-pages at 2025-02-04 16:46 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (a59ae8c) to head (6c01d3f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35047      +/-   ##
===========================================
- Coverage    59.22%   59.21%   -0.01%     
===========================================
  Files         2824     2824              
  Lines        68069    67989      -80     
  Branches     15151    15130      -21     
===========================================
- Hits         40314    40260      -54     
+ Misses       24924    24903      -21     
+ Partials      2831     2826       -5
Flag Coverage Δ
unit 75.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review January 29, 2025 15:47
@dougfabris dougfabris requested a review from a team as a code owner January 29, 2025 15:47
gabriellsh
gabriellsh previously approved these changes Jan 30, 2025
View reviewed changes
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Feb 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 4, 2025
@kodiakhq kodiakhq bot merged commit 6d78d70 into develop Feb 4, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the refactor/exhausting-types-videoconf branch February 4, 2025 18:03
@dougfabris dougfabris mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dougfabris @gabriellsh